Open
Conversation
great. now lets think you have a big script that you translated to german. and you added a new string. what will you do? you will say that you will update it in tsv file in notepad. but what if you make an accident there? from now on, when you extract a script, you can extract an updated script into the same tsv. for instance you have a german translated tsv file for a script. you add a new string in function _(), and you want to update tsv file. the existing german translations will not be lost and you will get new strings at the end of tsv file!
TheDcoder
requested changes
Feb 28, 2022
Owner
TheDcoder
left a comment
TheDcoder
left a comment
There was a problem hiding this comment.
Thank you for the PR! But I'd like to request some changes:
- Please avoid use of global variables
- Please use the proper case for functions and keywords in code, otherwise it looks unprofessional
- I think the lookup for existing strings can be improved by using a dictionary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
great. now lets think you have a big script that you translated to german. and you added a new string. what will you do? you will say that you will update it in tsv file in notepad. but what if you make an accident there? from now on, when you extract a script, you can extract an updated script into the same tsv. for instance you have a german translated tsv file for a script. you add a new string in function _(), and you want to update tsv file. the existing german translations will not be lost and you will get new strings at the end of tsv file!